RCP: 0.8.0, TXMEditor parameter toolbar is broken when CQP corpus is not ready
TXMEditor parameters toolbar is broken when a CQP corpus is not ready ->CQP exception are raised.
E.g. calling Cooccurrence on a not computed Sub-corpus throws a CQP exception when the Cooccurrence editor is opened and tries to load the available corpus properties.
Solution 1
When opening a TXMEditor always pre-compute the parent before. Add parent.compute(false) in
- a) TXMEditor.openEditor()
- b) TXMEditor.this.createPartControl
a) can manage the parent.compute in a job
b) always works but might cause freezes at any moment. ->maybe we
can use a busyWhile job to correctly freezes the interface
—->Use the b) solution and validate the freeze is ok
Solution 2
- protect all TXMResult getters methods with a this.compute(false)
Validation tests
WIP SJ:
- purpose here is to test on large corporas that contain not computed partitions or corpus that calling a command or reopening a result that are descendant to the not computed objects works as expected
(from redmine: issue id 2742, created on 2020/01/24 by Matthieu Decorde)
- Relations:
- Changesets:
- Revision 2558 by Sebastien Jacquot on 2020/01/27 13:57:35 +0100:
Fixes: Deleting a result node doesn't close its result children editors (refs #2679)
Progresses on: TXMEditor parameter toolbar is broken when CQP corpus is not ready (refs #2742)
Progresses on: Commands executed on not loaded Partition may lead to wrong results (refs #2682)
- Revision 2559 by Sebastien Jacquot on 2020/01/27 15:13:42 +0100:
Progresses on: TXMEditor parameter toolbar is broken when CQP corpus is not ready (refs #2742)
Progresses on: Commands executed on not loaded Partition may lead to wrong results (refs #2682)
- Revision 2565 by Sebastien Jacquot on 2020/01/28 15:58:26 +0100:
Progresses on: TXMEditor parameter toolbar is broken when CQP corpus is not ready (refs #2742)
Progresses on: Commands executed on not loaded Partition may lead to wrong results (refs #2682)
- Revision 2566 by Sebastien Jacquot on 2020/01/29 09:15:25 +0100:
Progresses on: TXMEditor parameter toolbar is broken when CQP corpus is not ready (refs #2742)
Progresses on: Commands executed on not loaded Partition may lead to wrong results (refs #2682)
- Revision 2579 by Sebastien Jacquot on 2020/01/30 12:21:05 +0100:
Progresses on: TXMEditor parameter toolbar is broken when CQP corpus is not ready (refs #2742)
Progresses on: Commands executed on not loaded Partition may lead to wrong results (refs #2682)