Skip to content

Editor results computing executed with not computed parents branch or too long process may lead to display wrong data in editor

WIP SJ:

There are most cases where an editor may seems ready to be used but actually doesn’t.
Behavior may be problematic according to the duration of the parents branch computing or duration of the result computing itself.

  • a) reopening a persisted result when its parent branch is not ready
  • b) computing a complex result

In both of these cases, if the duration is too long, the editor widget should be disabled or not opened before the computing has ended.
Otherwise, user can change parameters and run a compute leading to wrong result or simply some crashes due of various reasons.

Example of bug 1

There is a bug in 0.8.0 where the index of partition found nothing if the parent partition parts are not computed yet, typically when reopening TXM.
More information: the problem here is important. When creating an index of partition, the editor opens and the parent and children of parent are computed in background. But since the editor is ready, if we type eg. “faire” before the parts are computed, nothing is found in the index.

Steps to reproduce

=>have a Partition based on a complex query, eg. ELTECFRAORIG_sp_n
=>launch TXM execute Index with “faire” query
=>the editor and console return no results

Solutions to restrict and/or avoid the behavior of case a)

  • ensure the computing of parents branch is done before displaying the editor

SJ: solution has been implemented by running a modal cancelable dialog to block the UI until the needed parents branch is computed.
The editor is not displayed until the process has ended.
NOTE: later, it would be nice to manage a blocking state only for the concerned branch, so the user can still use TXM on other corpora or branches
New issue for this improvement and validation tests: #2746.

Solutions to restrict and/or avoid the behavior of case b)

    1. permit only one compute at a time in TXMEditor.Compute() by storing the current computing Job and returns if it’s already running
      =>will avoid the possibility to get some wrong results when the Partition is not yet computed (eg. typing “faire” in an Index does not return empty result anymore, atm this message is displayed in the console: “Editor is already computing …. Please wait or abort the computing job (Calcul de Index de partition: ELTECFRAORIG_sp_n: ……).”)
      =>It doesn’t avoid to open another Index
      SJ: this solution 1 has been implemented. Need to translate the log.

* 2) on computing, find a way to disable the editor widgets (or computing button) so the user can not start parallel computing
New issue for about this point here: #2747.

Validation tests

  • create and compute a complex result
  • while computing, change some parameters and click on compute button
    =>it should display a console alert
    =>when the first compute has ended, the parameter widget values must match the parameters used by the first compute

(from redmine: issue id 2682, created on 2019/11/29 by Sebastien Jacquot)

  • Relations:
  • Changesets:
    • Revision 2558 by Sebastien Jacquot on 2020/01/27 13:57:35 +0100:
Fixes: Deleting a result node doesn't close its result children editors (refs #2679)
Progresses on: TXMEditor parameter toolbar is broken when CQP corpus is not ready (refs #2742)
Progresses on: Commands executed on not loaded Partition may lead to wrong results (refs #2682)
  • Revision 2559 by Sebastien Jacquot on 2020/01/27 15:13:42 +0100:
Progresses on: TXMEditor parameter toolbar is broken when CQP corpus is not ready (refs #2742)
Progresses on: Commands executed on not loaded Partition may lead to wrong results (refs #2682)
  • Revision 2565 by Sebastien Jacquot on 2020/01/28 15:58:26 +0100:
Progresses on: TXMEditor parameter toolbar is broken when CQP corpus is not ready (refs #2742)
Progresses on: Commands executed on not loaded Partition may lead to wrong results (refs #2682)
  • Revision 2566 by Sebastien Jacquot on 2020/01/29 09:15:25 +0100:
Progresses on: TXMEditor parameter toolbar is broken when CQP corpus is not ready (refs #2742)
Progresses on: Commands executed on not loaded Partition may lead to wrong results (refs #2682)
  • Revision 2567 by Sebastien Jacquot on 2020/01/29 09:51:58 +0100:
Fixes: Dialog boxes of Sub-corpus and Partition creation are broken when CQP corpus is not ready (refs #2745)
Progresses on: Editor results computing executed with not computed parents branch or too long process may lead to display wrong data in editor (refs #2682)
  • Revision 2579 by Sebastien Jacquot on 2020/01/30 12:21:05 +0100:
Progresses on: TXMEditor parameter toolbar is broken when CQP corpus is not ready (refs #2742)
Progresses on: Commands executed on not loaded Partition may lead to wrong results (refs #2682)
  • Revision 2648 by Sebastien Jacquot on 2020/02/13 10:08:22 +0100:
Fixes: Editor results computing executed with not computed parents branch or too long process may lead to display wrong data in editor (refs #2682)