Infinite loop at TXM starting when deserializing a CA .prefs

recursion infinie lors de la réouverture de TXM si il y a une CA persistée
Caused by: java.lang.StackOverflowError
at java.security.AccessController.doPrivileged(Native Method)
at org.osgi.framework.FrameworkUtil.getBundle(FrameworkUtil.java:209)
at org.txm.core.results.TXMResult.autoSaveParametersFromAnnotations(TXMResult.java:1059)
at org.txm.core.results.TXMResult.setUserPersistable(TXMResult.java:2625)
at org.txm.core.results.TXMResult.setUserPersistable(TXMResult.java:2614)
at org.txm.ca.core.functions.CA.setUserPersistable(CA.java:1037)
at org.txm.core.results.TXMResult.setUserPersistable(TXMResult.java:2614)
at org.txm.ca.core.functions.CA.setUserPersistable(CA.java:1041)
at org.txm.core.results.TXMResult.setUserPersistable(TXMResult.java:2614)
at org.txm.ca.core.functions.CA.setUserPersistable(CA.java:1041)
at org.txm.core.results.TXMResult.setUserPersistable(TXMResult.java:2614)
at org.txm.ca.core.functions.CA.setUserPersistable(CA.java:1041)
at org.txm.core.results.TXMResult.setUserPersistable(TXMResult.java:2614)
at org.txm.ca.core.functions.CA.setUserPersistable(CA.java:1041)
at org.txm.core.results.TXMResult.setUserPersistable(TXMResult.java:2614)

Diagnostic

Bug has been introduced by adding:

@ // not an internal persistence (eg. corpus or partition)
if (!result.isInternalPersistable()) {
result.setUserPersistable(true);
}@

to org.txm.objects.Project.loadResults(Class) line 535
to restore the user persistable state.
It also leads to saving the .prefs files that have just been loaded.

Fixed by using a new method
public void setUserPersistable(boolean userPersistable, boolean doCheck)
that only sets TXMResult.userPersistable to true without any more check if doCheck is equal to false.

Since it removes some processes as resaving the .prefs.file, need to see with MD if it’s not break some special objects eg. Edition, Text, etc.

(from redmine: issue id 2677, created on 2019/11/28 by Sebastien Jacquot)

• Changesets:
  • Revision 2431 by Sebastien Jacquot on 2019/12/03 13:17:24 +0100:

Fixes: Infinite loop at TXM starting when deserializing a CA .prefs (refs #2677)
Fixes: Parts creation from a lazy loaded Partition seems to execute some actions twice (refs #2683)

added persistence type::bug + 1 deleted label

changed milestone to %TXM 0.8.1

Current state after some checks with MD:

- the fix described above has been validated

• we will later modify the solution in a way described here: http://forge.cbens-lyon.fr/redmine/issues/2687

(from redmine: written on 2019/12/04 by Sebastien Jacquot)

The bug has reappeared in trunk, need to check again and fix.

(from redmine: written on 2020/01/22 by Sebastien Jacquot)

Fixed again.

(from redmine: written on 2020/01/23 by Sebastien Jacquot)

closed

assigned to @sjacquot

added preferences tool::ca labels